Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm tests / fixed heuristic #647

Merged
merged 3 commits into from
Jun 23, 2020
Merged

evm tests / fixed heuristic #647

merged 3 commits into from
Jun 23, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

  • adjust the heuristic for non-payable function reverts to handle changes to sourceMap introduced in solc 0.6.9
  • adjust test parametrization to make it easier to run the tests against specific compiler versions
  • add a new CI job that always runs against the latest version of solc

How to verify it

Verify that CI passes.

matnad
matnad approved these changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@matnad matnad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iamdefinitelyahuman iamdefinitelyahuman merged commit 9e6378f into master Jun 23, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the evm-tests branch June 23, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matnad matnad matnad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamdefinitelyahuman @matnad